Question about adding old code

rnb5500 · Post by **rnb5500** » Mon Nov 04, 2013 2:23 pm

After scouring over PS3 Media Server site at google code I was able to isolate the old hdaudiopassthrough code. I've since added it back to UMS 3.0a5 and have been testing it a few weeks.

Obviously this is just a personal project and I have no desire to make it available, but not having any Java coding experience before this my question is how do I go about updating to UMS3.0 and newer builds as they come out but keep my added code intact. I mean without having to manually add the code to every build.

Thanx.

Optimus_prime · Post by **Optimus_prime** » Mon Nov 04, 2013 6:11 pm

We're looking at adding back in the hdaudiopassthrough code back in i think. You would have to add it in back in everytime i think mate, or try submitting it as a pull request to UMS git repo

Post by **SubJunk** » Mon Nov 04, 2013 6:26 pm

I would be interested in getting the code from you and just adding it back into our main code

rnb5500 · Post by **rnb5500** » Tue Nov 05, 2013 4:54 am

I was under the impression that hdaudiopassthrough (trying not to use the C word) was an avoided topic here and the code had legal concerns.
But if you want to add it that's even better, less work for me

Here's a link to what I've got:

https://drive.google.com/file/d/0B0Rk6M ... sp=sharing

Try not to laugh at my noob coding attempt

but much of the syntax has changed since PMS1.40 and it can't be injected directly so I did the best I could. I did test it and it does what its supposed to, encapsulate AC3 & DTS in LPCM, but I'm sure you guys will have room for improvement.

Post by **SubJunk** » Tue Nov 05, 2013 8:54 am

It's a useful feature to have without the C word anyway I think

Thanks a lot! You'll get credit in the changelog too

rnb5500 · Post by **rnb5500** » Tue Nov 05, 2013 9:44 am

I checked github and most of the affected files haven't changed since the 3.0a5 version I used, but some have.

Also this got me thinking about expanding the feature. I have some rips I've done where I encoded DTS-HD and TrueHD to AAC to save space under the assumption I could get similar quality as DTS core (and better than AC3) at lower bitrates.

So I'm wondering what it would take to encode other audio to AC3 and encapsulate it before streaming. It would seem all the parts are there to make it work. Your thoughts?

Post by **SubJunk** » Tue Nov 05, 2013 12:45 pm

If you know how to grab code from GitHub branches you can grab it from here https://github.com/UniversalMediaServer ... r/pull/145
I'm not sure about the new feature since it seems to me that encoding to AAC then AC-3 is introducing unnecessary quality loss, I wonder if it would be possible to encapsulate AAC?

rnb5500 · Post by **rnb5500** » Tue Nov 05, 2013 1:02 pm

I'm nearly done adding the code to the most recent files I just grabbed from github then I'll post them here. I'm not setup with github, maven, jdk etc to compile builds or upload changes to github because I just clean installed Win8.1 All I have is notepad++ right now.

**Edit: Here's the files
https://drive.google.com/file/d/0B0Rk6M ... sp=sharing

Post by **SubJunk** » Tue Nov 05, 2013 1:41 pm

I already added it to our code, it's at the link I posted

rnb5500 · Post by **rnb5500** » Tue Nov 05, 2013 1:44 pm

Oh ok cool.

AFA encapsulating AAC, guess it would depend on how many receivers & TVs support AAC decoding to decide if it would be worthwhile.

Universal Media Server | Forum

Question about adding old code

Question about adding old code

Re: Question about adding old code

Re: Question about adding old code

Re: Question about adding old code

Re: Question about adding old code

Re: Question about adding old code

Re: Question about adding old code

Re: Question about adding old code

Re: Question about adding old code

Re: Question about adding old code