MovieInfo

Discuss third party additions, plugins and translations for Universal Media Server
User avatar
SharkHunter
Developer
Posts: 669
Joined: Fri Jun 01, 2012 9:36 pm

Re: MovieInfo

Post by SharkHunter » Fri Mar 15, 2013 7:36 pm

@ExSport - No I don't think I store the posters from the scan. Since the main objective was to get a new "browse" order the poster url is stored in the db and used as thumb for the movie when browsing via the movieDB. Could of course be changed. And currently nope data is not fetched from the db since not all data is stored there (it doesn't store plot/tagline) this is a future improvement.
We reject: kings, presidents and voting.
We believe in: rough consensus and running code.

ExSport
Posts: 596
Joined: Wed Oct 10, 2012 1:57 am

Re: MovieInfo

Post by ExSport » Fri Mar 15, 2013 9:32 pm

Ok, thanks for info.
I asked because I read many times people asked for automatic poster download instead of browsing all movies via MOVIEINFO folder.
I think it will be great to be configurable so who want it, posters will be stored next to video file so pure browsing can benefit from it.
Also it will be great to prescan movie info via SCAN button so also people who don't want to play movie from MovieDB folder, they will be able to read movie info directly from MOVIEINFO folder without the need to be connected to internet or downloading movie info again and again. Only as a tip.
Did you figured what is wrong with csfd plugin? Is it UTF-8 as I advised or something else? Because your non-MovieDB jar file works OK 8-)
If you will support "/" divider directly in main code, it will be great :)
Many thanks, will test it today hopefully.

User avatar
SharkHunter
Developer
Posts: 669
Joined: Fri Jun 01, 2012 9:36 pm

Re: MovieInfo

Post by SharkHunter » Fri Mar 15, 2013 9:42 pm

I added the MovieDB stuff as a response to viewtopic.php?f=4&t=701 and to some friends of mine having the same issues. It is an early start (I did it simple) and some of points you make I thought of and I'm certain I'll update stuff. Stashing all the data into the db is something I'll add. It is possible to store the images into the db directly but maybe that has some space issues maybe. I'll think about it...

I haven't looked into the UTF stuff. Just weird

Edit. BTW I saw that IMDB got metascore as a field. I thought I'll ad that as a new field to display as it might complement rating...DOn't know how the other sites have it?
We reject: kings, presidents and voting.
We believe in: rough consensus and running code.

ExSport
Posts: 596
Joined: Wed Oct 10, 2012 1:57 am

Re: MovieInfo

Post by ExSport » Sat Mar 16, 2013 1:54 am

I understand, make it easy as possible :mrgreen:
I reported bugs only and add some tips if it will be useful also for others.
Benefit of not storing picture in DB is as you said size issue or if whole DB is loaded to memory, then also RAM issue. Another benefit of storing picture in movie folder is that renderer can display it as a folder or movie poster but then it will not be visible when browsed via MovieDB I suppose. All have cons and pros...
About the CSFDplugin. I unpacked your compiled new and old version and I am sure problem is different codepage of imported project/final compilation.
When I unpacked old one and displayed part with diactrics as UTF-8 I see:

Code: Select all

alt="Odrážka"
With new code:

Code: Select all

alt="Odrážka"
When you will set different encoding than UTF-8 for project in Eclipse, parsing of special chars is not correct so plugin doesn't work correctly ;)
About the metascore. I don't think it is problem when others don't support it. Because of that you can choose which tags to display:

Code: Select all

DisplayInfo=title,tagline,rating,genre,director,cast,plot,agerating
Eg. CSFD.CZ don't have "Tagline" so I used it for showing "Country, Year, Length" like "USA, 2011, 148 min" which original IMDB plugin can't retrieve but it is useful info 8-)

ExSport
Posts: 596
Joined: Wed Oct 10, 2012 1:57 am

Re: MovieInfo

Post by ExSport » Sun Mar 17, 2013 1:51 am

Compiled your latest code (project set to UTF-8) and CSFD part works OK now so problem is codepage on your side 8-)
Anyway I found a bug. When

Code: Select all

movieinfo.movieDB=true
plugin shows different results than when it is set to false.
Movie TRANSFORMERS 3 and all casts parsed from CSFD.CZ web:
Shia LaBeouf, Rosie Huntington-Whiteley, Frances McDormand, Hugo Weaving, John Turturro, Tyrese Gibson, John Malkovich, Patrick Dempsey, Ken Jeong, Alan Tudyk, Peter Cullen, Kevin Dunn, Josh Duhamel, Keiko Agena, Frank Welker, Leonard Nimoy, Tom Kenny, Karyn Parsons, Glenn Morshower, Robert Foxworth, Charles Adler, Kym Whitley, Mark Ryan, Jess Harnell, Darren O'Hare, David St. James, Andrew Daly, Jesse Heiman, Inna Korobkina, James Remar, Anthony Azizi, Matthew James Gulbranson, Francesco Quinn, Michael Dorn, Elya Baskin, Iqbal Theba, Julie White, Reno Wilson, George Coe, Ron Bottitta, Christopher Mur
When DB is disabled casts are displayed from first actor but when enabled casts starting from Glenn Morshower.
EDIT:
Ehm, same for IMDB plugin :mrgreen:
Also I spotted many exceptions in file "movieDB.trace.db"
I tried to scan recursively with CSFD and IMDB enabled. Unfortunately info is not gathered but when I manually browsed MOVIEINFO folder, both plugin works and loads web info.
When SCAN button pressed, it generates:

Code: Select all

DEBUG 2013-03-16 16:25:35.825 [Library Scanner] scan dir d:\_Test
DEBUG 2013-03-16 16:25:36.047 [Library Scanner] fetch imdbid for hash ea829b8d093fe743
DEBUG 2013-03-16 16:25:36.197 [Library Scanner] couldn't fetch imdbid d:\_Test\2.0-5.1\2.13-Pinda.Heksen.S05E01.720p.HDTV.x264-NLsubs (1)-001.mkv
DEBUG 2013-03-16 16:25:36.204 [Library Scanner] fetch imdbid for hash 86ab79da787825f1
DEBUG 2013-03-16 16:25:36.260 [Library Scanner] MovieInfo - Resolved link for gathering data: http://www.imdb.com/title/tt0758745/
DEBUG 2013-03-16 16:25:37.121 [Library Scanner] error java.net.MalformedURLException: no protocol: 
DEBUG 2013-03-16 16:25:37.206 [Library Scanner] fetch imdbid for hash 0000000000000000
DEBUG 2013-03-16 16:25:37.245 [Library Scanner] couldn't fetch imdbid d:\_Test\Nenitunic\x.pdf
DEBUG 2013-03-16 16:25:37.250 [Library Scanner] fetch imdbid for hash 38806f80964f5a4d
DEBUG 2013-03-16 16:25:37.290 [Library Scanner] couldn't fetch imdbid d:\_Test\OutOfSync\Wimate_V1.0.1.exe
DEBUG 2013-03-16 16:25:37.294 [Library Scanner] fetch imdbid for hash b223abafb5cfa1d3
DEBUG 2013-03-16 16:25:37.349 [Library Scanner] couldn't fetch imdbid d:\_Test\OutOfSync\Wimate_V1.1.20.apk
DEBUG 2013-03-16 16:25:37.353 [Library Scanner] fetch imdbid for hash d4c3f77ff3b0cb88
DEBUG 2013-03-16 16:25:37.394 [Library Scanner] couldn't fetch imdbid d:\_Test\OutOfSync\[HorribleSubs] Maoyuu Maou Yuusha - 03 [1080p].mkv
DEBUG 2013-03-16 16:25:37.401 [Library Scanner] fetch imdbid for hash 2107f76a3c23e355
DEBUG 2013-03-16 16:25:37.451 [Library Scanner] couldn't fetch imdbid d:\_Test\Sample-StereoToSurround.mkv
DEBUG 2013-03-16 16:25:37.459 [Library Scanner] fetch imdbid for hash 72f771125d2ea8f1
DEBUG 2013-03-16 16:25:37.501 [Library Scanner] couldn't fetch imdbid d:\_Test\sample.mkv
DEBUG 2013-03-16 16:25:37.517 [Library Scanner] fetch imdbid for hash 7d40e25a131a70c8
DEBUG 2013-03-16 16:25:37.556 [Library Scanner] couldn't fetch imdbid d:\_Test\sample.mkv.cover.jpg
DEBUG 2013-03-16 16:25:37.567 [Library Scanner] fetch imdbid for hash 34ea5940f0cc5986
DEBUG 2013-03-16 16:25:37.606 [Library Scanner] couldn't fetch imdbid d:\_Test\Sync Test - AC3_5-minute-sample-277mb.mp4
DEBUG 2013-03-16 16:25:37.610 [Library Scanner] fetch imdbid for hash 3e9bcedb01abd115
DEBUG 2013-03-16 16:25:37.660 [Library Scanner] couldn't fetch imdbid d:\_Test\Ted\Sample\ftu-720-ted-sample.mkv
DEBUG 2013-03-16 16:25:37.664 [Library Scanner] fetch imdbid for hash 4a2f05bbd015152d
DEBUG 2013-03-16 16:25:37.718 [Library Scanner] couldn't fetch imdbid d:\_Test\The Watch\Transformers 3.avi
DEBUG 2013-03-16 16:25:37.722 [Library Scanner] fetch imdbid for hash 73f699938c9327a9
DEBUG 2013-03-16 16:25:37.771 [Library Scanner] couldn't fetch imdbid d:\_Test\The Watch\Transformers 3.avi.cover.jpg

Now I tried to enable CSFD only but log is same as above. Why "Transformers 3" is not automatically found (same with IMDB) and why IMDB link was found for "SubJunk_Friday.Night.Lights.S01E03.DVDRip.XviD-TOPAZ.avi" file. I understand when IMDB is enabled, but when IMDB is disabled and CSFD is enabled only?
This file is not in log but it is represented with "MovieInfo - Resolved link for gathering data: http://www.imdb.com/title/tt0758745/"
I expect when CSFD is set as a plugin, also autoscan will use same settings and not IMDB (is it hardcoded?)
Anyway for both plugins Transformers is not found via SCAN button.
Maybe also it is better to scan for movie files only and not for pdf, nfo, jpg etc. to avoid incorrect results.
Hope it helps :idea:

User avatar
SharkHunter
Developer
Posts: 669
Joined: Fri Jun 01, 2012 9:36 pm

Re: MovieInfo

Post by SharkHunter » Sun Mar 17, 2013 8:44 pm

The cast stuff was a bug I've fixed (I missed some in the cast list handling).
I've added checks to only scan videofiles so that should improve the scan speed :)

Currently it's hardcoded to go to IMDB but that will change in the future...
I'll push some more stuff.
We reject: kings, presidents and voting.
We believe in: rough consensus and running code.

ExSport
Posts: 596
Joined: Wed Oct 10, 2012 1:57 am

Re: MovieInfo

Post by ExSport » Sun Mar 17, 2013 9:50 pm

Great thanks.
Also I spotted that it doesn't count with the settings of the plugin where I disabled showing AgeRating so in MOVIEINFO folder it is not visible but MovieDB has hardcoded it because it is visible.
But as you said, imdb and other settings is hardcoded so I am waiting for next version to test 8-)
Thx!

User avatar
SharkHunter
Developer
Posts: 669
Joined: Fri Jun 01, 2012 9:36 pm

Re: MovieInfo

Post by SharkHunter » Wed Mar 20, 2013 8:05 am

Hi,

I've made a big update of the new MovieDB fetaure try it out.

https://code.google.com/p/sharkhunter-s ... loads/list
We reject: kings, presidents and voting.
We believe in: rough consensus and running code.

ExSport
Posts: 596
Joined: Wed Oct 10, 2012 1:57 am

Re: MovieInfo

Post by ExSport » Thu Mar 21, 2013 8:49 am

Great, thx :)
Short test:
  • CSFD plugin works when browsed via MOVIEINFO folder so UTF-8 problem fixed 8-)
  • I enabled IMDB only. When browsed manually "Transformers 3.avi" via MOVIEINFO, info is shown and saved in DB but when I then browsed it via MovieDB folder I can see folders Genre, Title, Director, Rating and Cast. All includes gathered info but not folder Title. This folder displays "Transformers 3 (2011)" folder after UMS restart only, not directly. When I repeated test folder was visible without restart. Weird.
  • When I enabled IMDB only and gathered data via SCAN button, "Transformers 3.avi" was ignored because no info found. This was written to log:

    Code: Select all

    TRACE 2013-03-20 16:24:19.314 [Library Scanner] Matched format MPG to "d:\_Test\The Watch\Transformers 3.avi"
    DEBUG 2013-03-20 16:24:19.345 [Library Scanner] fetch imdbid for hash 4a2f05bbd015152d
    DEBUG 2013-03-20 16:24:19.374 [Library Scanner] couldn't fetch imdbid d:\_Test\The Watch\Transformers 3.avi
    [/size]
    What I spotted is that when path for scan is not defined in plugin (set only as a share, folder D:\_Test), plugin logs " [Library Scanner] Checking shared folder: D:\_Test" but that's all. Nothing is scanned.
    When I defined same folder also in plugin, it started to scan with results above, that imdbid couldn't be fetched.
    Also when I pressed scan, it found one movie [Friday Last Night] which was visible via MovieDB, then I browsed MOVIEINFO folder to gather also "Transformers 3". What I spotted is that CAST is not visible? Also manually browsed "Transformers 3" is not shown(refreshed) in MovieDB folder. UMS restart fixed it. Also CAST is visible there(but not in MOVIEINFO folder). Another thing is that CAST categorizing is done on name and not surname.
  • And finally I enabled CSFD only. Same bug that CAST is not visible via MOVIEINFO folder but it is saved to DB and also Title is visible in MovieDB without need of restart(with IMDB restart was needed)
    When I tried SCAN button, again plugin tried to gather data [Friday Last Night] via IMDB and not via CSFD. "Transformers 3" wasn't found again as above and also MOVIEINFO folder now shows info for [Friday Last Night] from IMDB and not via CSFD! So I suppose it was loaded from DB (which uses IMDB only when SCAN is used) and not gathered again.
    And last thing is that it seems to me that SCAN button found different info from IMDB against what is found when I browsed MOVIEINFO manually (IMDB). Totally weird and unconsistend results from my tests :?
Here is the settings what I use but it seems when SCAN button is used, gathering is called via imdb plugin only and also it ignores(don't loads) my internal settings (from conf file) of "Filter,ILanguage,DisplayInfo" etc. and because of that different results are found??

Code: Select all

Plugins=IMDB
NumberOfActors=7
Cover=1
DisplayInfo=title,tagline,rating,genre,director,cast,plot
Linelength=45
cellwrap=0
showtags=true
ILanguage=cs
RemoveYear=false
Filter=.......
[/size]
Keep up good work ;) But still not usable for me :|
EDIT: Attaching generated DB trace from my tests full of SQL exceptions...
Attachments
movieDB.trace.zip
SQL exceptions
(6.94 KiB) Downloaded 209 times

User avatar
geaves
Posts: 48
Joined: Wed Apr 17, 2013 2:24 am
Location: Essex, UK

Re: MovieInfo

Post by geaves » Wed Apr 17, 2013 2:26 am

I keep getting the following error, when this is loading....attached debug.log

*Scrub that....reinstalled and seems to working.
Attachments
ums_dbg.zip
(14.84 KiB) Downloaded 204 times

Post Reply