HELP about UMS code understanding
Forum rules
Please make sure you follow the Problem Reporting Guidelines before posting if you want a reply
Please make sure you follow the Problem Reporting Guidelines before posting if you want a reply
HELP about UMS code understanding
Hello,
when i read your code in RendererConfiguration.java :
i am wondering if it's meaning that when we choice "Automatic audio resampling to 44.1 or 48 khz" option, in Transcoding Settings -> FFmpeg Audio, it's automatically convert to 2 channels ?
If it's really the case, i think it will be nice to advice it and add "(2 channels)" after "Automatic audio resampling to 44.1 or 48 khz" (It could be useful/meaningful for users having Home Cinema or good external audio system).
Why 2 channels by default and not the value defined in the renderer.conf ? and if the value is not defined, advertise that it will be 2 channels by default.
If it is for MEncoder limitation, i guess we can avoid using it for audio only ?
when i read your code in RendererConfiguration.java :
Code: Select all
if (matchedMimeType != null) {
if (pmsConfiguration.isAudioResample()) {
if (isTranscodeAudioTo441()) {
matchedMimeType += ";rate=44100;channels=2";
} else {
matchedMimeType += ";rate=48000;channels=2";If it's really the case, i think it will be nice to advice it and add "(2 channels)" after "Automatic audio resampling to 44.1 or 48 khz" (It could be useful/meaningful for users having Home Cinema or good external audio system).
Why 2 channels by default and not the value defined in the renderer.conf ? and if the value is not defined, advertise that it will be 2 channels by default.
If it is for MEncoder limitation, i guess we can avoid using it for audio only ?
