MovieInfo

Discuss third party additions, plugins and translations for Universal Media Server
User avatar
SharkHunter
Developer
Posts: 669
Joined: Fri Jun 01, 2012 9:36 pm

Re: MovieInfo

Post by SharkHunter » Wed Mar 13, 2013 8:54 pm

ExSport - could you pull the latest code and try out the new "MovieDB" feature? (Do it in a "experiment" dir since it is rather time consuming). And if possible try and use CSFD instead of IMDB (it should be possible to swap fairly easy I think...).
We reject: kings, presidents and voting.
We believe in: rough consensus and running code.

ExSport
Posts: 596
Joined: Wed Oct 10, 2012 1:57 am

Re: MovieInfo

Post by ExSport » Thu Mar 14, 2013 8:56 pm

Had no time to test deeper but first what I spotted it seems you loaded code not as UTF-8?
My plugin without MovieDB works but not your.
Try naming file like Transformers 3.avi
My Plugin compiled as UTF-8 works OK with CSFD but your not. Compare both to see the difference ;) My code includes special chars so now it seems these chars are not found so garbage is shown - I am almost sure it is problem of non UTF-8 code import.
Also it seems your plugin doubles the output when I went back to MovieInfo folder. EDIT:Can't reproduce again...
Tested in eezUPnP, later will try XMBC...
Last edited by ExSport on Thu Mar 14, 2013 9:45 pm, edited 1 time in total.

User avatar
SharkHunter
Developer
Posts: 669
Joined: Fri Jun 01, 2012 9:36 pm

Re: MovieInfo

Post by SharkHunter » Thu Mar 14, 2013 9:18 pm

UTF-8!?? No idea. Eclipse played some trick on me? Or it works for me so what do I know.

I'll dig deeper...
We reject: kings, presidents and voting.
We believe in: rough consensus and running code.

ExSport
Posts: 596
Joined: Wed Oct 10, 2012 1:57 am

Re: MovieInfo

Post by ExSport » Thu Mar 14, 2013 9:35 pm

Line 39 of CSFDPlugin.java:
Correct one [UTF-8]:

Code: Select all

				title = title.replace(" | ČSFD.cz", "");
and wrong one [some ISO]:

Code: Select all

				title = title.replace(" | ČSFD.cz", "");
If encoding is wrong, then plugin will not correctly parse text so different output for your new plugin and the old one? Only my 2 cents 8-)
Attachments
Eclipse_encoding.png
Eclipse encoding
Eclipse_encoding.png (7.68 KiB) Viewed 5744 times

ExSport
Posts: 596
Joined: Wed Oct 10, 2012 1:57 am

Re: MovieInfo

Post by ExSport » Thu Mar 14, 2013 9:55 pm

Here the difference (ignore bad chars... it is problem of eezUPnP, in XBMC chars are ok)
First one shows ČSFD.CZ in title name what should be filtered. And from "Director" none is parsed correctly so not showed at all?
Attachments
csfd-bad.png
CSFD -Bad
csfd-bad.png (6.19 KiB) Viewed 5742 times
csfd-ok.png
CSFD - OK
csfd-ok.png (37.46 KiB) Viewed 5742 times

ExSport
Posts: 596
Joined: Wed Oct 10, 2012 1:57 am

Re: MovieInfo

Post by ExSport » Fri Mar 15, 2013 6:03 am

Scan doesn't work recursively. I am sharing folder D:\_Test where are some files and folders. Files in root are scanned but not folders so test file Transformers 3.mkv in D:\_Test\Watch\Transformers 3.mkv is ignored.
When I browse there manually (via old "MovieInfo folder"), data are gathered and saved to DB 8-)
I spotted that as a Director directly in MOVIEINFO folder is shown "Michael Bay" but in MovieDB under Director category there is a extra POINT at the end "Michael Bay."
When I defined path manually, it doesn't help. Still folder is not scanned recursively.
Anyway good job 8-)
EDIT:
Genre category is parsed by "," [IMDB] but CSFD plugin uses "/". Should I change it in CSFDPlugin itself or is it possible to change it in your code? I like "/" more than "," when displaying on TV and also it is native divider on CSFD.CZ site 8-)
Thx

User avatar
SharkHunter
Developer
Posts: 669
Joined: Fri Jun 01, 2012 9:36 pm

Re: MovieInfo

Post by SharkHunter » Fri Mar 15, 2013 6:38 am

The recursing was left out on purpose since I wanted it be a bit defensive in the start. It will be added later.

Yeha each time you enter MoveInfo and DB is enabled it will gather the data...

Yeah , would be good or I can add support for both?
The . should be removed...
We reject: kings, presidents and voting.
We believe in: rough consensus and running code.

nonolk
Posts: 6
Joined: Wed Nov 07, 2012 9:03 pm

Re: MovieInfo

Post by nonolk » Fri Mar 15, 2013 8:05 am

Hello Sharkhunter,

I tried setted the parameter you gave for limiting the number of actor to 7, but this is never taken in account by the pluging.
What ever I do, for example changing the plugin order.
It's also never taken in account.

I hope this will help.

Best regards,
--
Nonolk.

User avatar
SharkHunter
Developer
Posts: 669
Joined: Fri Jun 01, 2012 9:36 pm

Re: MovieInfo

Post by SharkHunter » Fri Mar 15, 2013 9:02 am

ExSport - I've updated the IMDb slightly so the . is gone :)

I added a moiveinfo.movieDB_recurse option which if set to true recurse into sub folders. Try it out.
We reject: kings, presidents and voting.
We believe in: rough consensus and running code.

ExSport
Posts: 596
Joined: Wed Oct 10, 2012 1:57 am

Re: MovieInfo

Post by ExSport » Fri Mar 15, 2013 9:18 am

@nonolk: plugin GUI never worked. You have to edit movieinfo.conf file directly.
@SharkHunter, many thanks. Will test it tomorrow. And what about csfd bug that not all info is retrieved?
Thank
Edit: One question. When scan button is used from plugin GUI, are posters saved next to the movie file like when browsed manually? Forgot to test it:-)
Second one, when movie info is already in db and I will browse movieinfo folder manually, data are checked online or loaded from db after restart?

Post Reply